Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add og:image:alt and twitter:image:alt #438

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Mar 7, 2021

Twitter documentation https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image

twitter:image:alt
A text description of the image conveying the essential nature of an image to users who are visually impaired. Maximum 420 characters.

Facebook / OG cocumentation

og:image:alt - A description of what is in the image (not a caption). If the page specifies an og:image it should specify og:image:alt.

Closes #395

Copy link

@nickmccurdy nickmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks. Are you aware if it's possible to Jekyll to warn when image is used without alt though?

@nickmccurdy nickmccurdy mentioned this pull request Mar 18, 2021
@tordans
Copy link
Contributor Author

tordans commented Mar 18, 2021

This looks great, thanks. Are you aware if it's possible to Jekyll to warn when image is used without alt though?

No I would not know how Jekyll could do that; and don't think it's the intended behavior of this plugin - it does not warn anywhere else…

docs/advanced-usage.md Outdated Show resolved Hide resolved
lib/template.html Outdated Show resolved Hide resolved
Twitter documentation https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image
> twitter:image:alt
A text description of the image conveying the essential nature of an image to users who are visually impaired. Maximum 420 characters.

Facebook / OG cocumentation
> og:image:alt - A description of what is in the image (not a caption). If the page specifies an og:image it should specify og:image:alt.

Closes jekyll#395
tordans added a commit to tordans/jekyll-seo-tag that referenced this pull request Oct 8, 2021
Following jekyll#438 (comment) this cleans up the non-needed new line. All other groups in this file are separated by one new line.
@tordans
Copy link
Contributor Author

tordans commented Oct 8, 2021

@ashmaroli review changes are applied and squashed; branch is rebased to current master.

Let me know if there is anything left to do.

@mattr-
Copy link
Member

mattr- commented Nov 22, 2021

Waiting for CI to come back green and will merge then.

@mattr-
Copy link
Member

mattr- commented Nov 22, 2021

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 4a590c9 into jekyll:master Nov 22, 2021
jekyllbot added a commit that referenced this pull request Nov 22, 2021
@jekyll jekyll locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify og:image:alt
5 participants