-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add og:image:alt
and twitter:image:alt
#438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks. Are you aware if it's possible to Jekyll to warn when image
is used without alt
though?
No I would not know how Jekyll could do that; and don't think it's the intended behavior of this plugin - it does not warn anywhere else… |
Twitter documentation https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image > twitter:image:alt A text description of the image conveying the essential nature of an image to users who are visually impaired. Maximum 420 characters. Facebook / OG cocumentation > og:image:alt - A description of what is in the image (not a caption). If the page specifies an og:image it should specify og:image:alt. Closes jekyll#395
Following jekyll#438 (comment) this cleans up the non-needed new line. All other groups in this file are separated by one new line.
@ashmaroli review changes are applied and squashed; branch is rebased to current master. Let me know if there is anything left to do. |
Waiting for CI to come back green and will merge then. |
@jekyllbot: merge +minor |
Twitter documentation https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image
Facebook / OG cocumentation
Closes #395