Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set type for author #427

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

eliasfroehner
Copy link
Contributor

Referring to https://schema.org/author the values Organization and Person are supported

Referring to https://schema.org/author the values Organization and Person are supported
@DarkWiiPlayer
Copy link

This addresses one possible use case of my recent pull request but makes it a lot less hacky. It'd be nice if they could both be merged to make this plugin viable for sites other than blogs. 🎆 🎊

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes needed..

lib/jekyll-seo-tag/json_ld_drop.rb Outdated Show resolved Hide resolved
lib/jekyll-seo-tag/json_ld_drop.rb Outdated Show resolved Hide resolved
lib/jekyll-seo-tag/json_ld_drop.rb Outdated Show resolved Hide resolved
@ashmaroli ashmaroli requested a review from a team January 11, 2021 08:51
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@ashmaroli
Copy link
Member

Thank you @api-walker
@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 9cb1ad0 into jekyll:master Jan 11, 2021
jekyllbot added a commit that referenced this pull request Jan 11, 2021
@jekyll jekyll locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants