Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default og:type to 'website' #391

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Set the default og:type to 'website' #391

merged 3 commits into from
Oct 8, 2021

Conversation

CodeSandwich
Copy link
Contributor

If the page doesn't have a date, og:type is not set. This PR attempts to fix that.

@LorenzBung
Copy link

Relevant update for #389

@neilconway
Copy link

Any updates on this? Would be nice to have this fix -- og:type is mandatory.

@LorenzBung
Copy link

Any updates on this? Would be nice to have this fix -- og:type is mandatory.

The way I see it, this PR should be ready to be merged as it fixes og:type being unassigned.
The type itself might be changed in a separate PR, but as far as I understand it, this one is only there to set a default value.

@PardhuMadipalli
Copy link

Why is nobody reviewing this PR? This is an important fix.

@jaredcwhite jaredcwhite mentioned this pull request Aug 12, 2021
Closed
ashmaroli
ashmaroli approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ashmaroli
Copy link
Member

Thanks @CodeSandwich
@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit f1b9828 into jekyll:master Oct 8, 2021
jekyllbot added a commit that referenced this pull request Oct 8, 2021
@jekyllbot
Update history to reflect merge of #391 [ci skip]
36330e8
@CodeSandwich CodeSandwich deleted the patch-1 branch October 8, 2021 12:43
@jacobherrington jacobherrington mentioned this pull request Nov 17, 2021
Merged
@jekyll jekyll locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmaroli ashmaroli ashmaroli approved these changes

@PardhuMadipalli PardhuMadipalli PardhuMadipalli approved these changes

Assignees
No one assigned
Labels
bug fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CodeSandwich @LorenzBung @neilconway @PardhuMadipalli @ashmaroli @jekyllbot