Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a new release #122

Closed
jekyllbot opened this issue Aug 10, 2021 · 12 comments
Closed

Time for a new release #122

jekyllbot opened this issue Aug 10, 2021 · 12 comments

Comments

@jekyllbot
Copy link
Contributor

Hello, maintainers! 👋

By my calculations, it's time for a new release of jekyll-sass-converter. It's been over 2 months since the last release, v2.1.0.

What else is left to be done before a new release can be made? Please make sure to update History.markdown too if it's not already updated.

Thanks! 💞 ✨

@manunamz
Copy link

Can this implementation from this issue be merged/replace jekyll-sass-converter?

@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@Listor
Copy link

Listor commented Oct 19, 2021

Can this implementation from this issue be merged/replace jekyll-sass-converter?

I would also like this implementation to be shipped so i can use it. My project relies on a service that can't use anything other than a released version so it would help a lot :)

@jekyllbot jekyllbot removed the stale label Oct 19, 2021
@jekyllbot
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

@BenSouchet
Copy link

Hi,
I'm also interested by a new released version 🙂

Is there any news ? who are the current project maintainers with the ability to create a new release ? @parkr ?

Thanks in advance

@jekyllbot jekyllbot removed the stale label Jan 9, 2022
@BenSouchet
Copy link

BenSouchet commented Jan 11, 2022

@ashmaroli or @mattr-
Hi, If you have some time to do a new release 🥇 🙂

@BenSouchet
Copy link

I know I'm a little pushy but I would really like to be able to use Dart Sass implementation and for that a new release must be made, @parkr or @DirtyF maybe if you have time and can do it that would be awesome !

@ashmaroli
Copy link
Member

@BenSouchet Personally, I'm not entirely confident of the stability of underlying libraries:

They're still in beta.
You're however, free to try using the stack by editing your Gemfile:

# Gemfile

gem "jekyll-sass-converter", github: "jekyll/jekyll-sass-converter"

@BenSouchet
Copy link

BenSouchet commented Jan 17, 2022

@ashmaroli Thanks but since I'm using the default Github Pages action, adding this line in my Gemfile file won't work, this is the answer @ntkme give me by email:

It won’t work directly on GH Pages because: jekyll-sass-converter has not cut a release with this new feature, meaning you have to manually setup Jekyll and dependency gems. Also, GH pages have a whitelist of allowed plugin, and this one is not there yet.

However, there is an alternative, use GitHub Action to build your site with jekyll (you can use whatever plugin/gems this way), and then have GitHub Action push the result to a different branch to serve GitHub pages.

So without using a custom action I can't use the current jekyll-sass-converter master version (with the Dart Sass implementation).

Since the goal with my project is to create a one-click theme I want to stick with GH Pages with the default action, so I'm currently stuck.

Other point, to answer your concern with the fact that underlying libraries are in beta, since the implementation: sass-embedded is only an option, it's less dramatic that these libraries are in beta. Plus theses libraries are in active development. So releasing a new version of jekyll-sass-converter can only be beneficial for these libraries.

@ashmaroli
Copy link
Member

So without using a custom action I can't use the current jekyll-sass-converter master version..

@BenSouchet GitHub Pages is locked to these versions.
Note the sass-converter plugin in use there is currently 1.x? The version we'll be releasing next will be 2.2.0.
So, just like how you can't use Jekyll 4 with GHP, there's no guarantee that GHP will bump to the new version because of the major-version moat. Additionally, I doubt they'll be willing to go onboard with the aforementioned beta gems. (They do take second-order dependencies into consideration.)

Try getting them to bump to jsc-2.1.0 first.

My sincere recommendation is to forego native GHP deploys and use a third-party / custom GH action. You have greater control and freedom.

@BenSouchet
Copy link

@ashmaroli I didn't know that Github dependencies for jekyll-sass-converter was still version 1.5.2 outch.

Yeah, I think I will forget GHP native deployment 😞

Thanks for the info, by the way I asked on pages-gem repository why the dependencies checker haven't bump to the new versions for jekyll-sass-converter, still interesting to understand the reasons or limitations behind this.

@parkr
Copy link
Member

parkr commented May 17, 2022

Looks like all the PRs that have been merged have been released according to https://github.com/jekyll/jekyll-sass-converter/blob/master/History.markdown

@jekyllbot jekyllbot removed the stale label May 17, 2022
@jekyll jekyll locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants