chore(deps): rubocop-jekyll 0.3 #187
Merged
+27
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Oct 26, 2018
| # SupportedStylesForLeadingUnderscores: disallowed, required, optional | ||
| Naming/MemoizedInstanceVariableName: | ||
| Exclude: | ||
| - 'lib/jekyll-redirect-from/page_without_a_file.rb' |
There was a problem hiding this comment.
There's point marking this as a TODO.. It can never be "fixed"..
Best we add an inline comment to disable-reenable the cop
There was a problem hiding this comment.
I don't like inline comments, I'd rather keep it here, even if it's not "fixable".
ashmaroli
reviewed
Oct 26, 2018
| # AllowedNames: io, id, to, by, on, in, at, ip, db | ||
| Naming/UncommunicativeMethodParamName: | ||
| Exclude: | ||
| - 'lib/jekyll-redirect-from/redirect_page.rb' |
There was a problem hiding this comment.
Can't this be fixed within this PR itself..?
There was a problem hiding this comment.
Feel free to fix it in a dedicated PR.
|
@jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR automatically created for @DirtyF.