Make amount of posts in feed configurable

[Enteee]

Feature

I would like to see the amount of posts included in the feed configurable.

Background

On https://duckpond.ch I use https://github.com/chinchang/super-search for server less full text search. And that uses the atom feed generated by this plugin. (hit ESCAPE on the page). Now it would be nice to bump the number of posts in the feed a bit higher in order to provide full text search on more articles.

[joereynolds]

Agreed.
Judging from the past though they seem quite hesistant and even resistant to add such an option.
They're sacrificing usability and a user's experience for the sake of not adding a config option, which to me, seems a bit silly.

[Enteee]

Thank you for the links @joereynolds. I skimmed through those (and some of the linked ones from them as well) but couldn't find a reason why this was never implemented. Weird..

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[Enteee]

@jekyllbot bad bot.

... more than 80% of users would find this beneficial.

This is obvious from all the closed issues in the past.

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[Enteee]

bad bot

[parkr]

Would something like this help you retrieve more results? #236

It sounds a little bit like you want a searchable index of the whole site. A feed is not a site index, so the semantics are a bit off there.

[Enteee]

Would something like this help you retrieve more results? #236

sort of. I just think that this is going a bit too far for the simple requirement that i am having.

It sounds a little bit like you want a searchable index of the whole site. A feed is not a site index, so the semantics are a bit off there.

Yes a searchable index would be nice.. Considering that I am only interested in finding results in the last few posts (more than 10). I do think (ab)using the feed for that suits.

[mhennessie]

I would also be interested in this for a different reason. I am in the process of migrating a Jekyll site to Wordpress for a client. If I could expose more posts in the RSS feed then I could run an import and pull all of the posts into Wordpress.

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[Enteee]

@jekyllbot bad 🤖 !

[jekyllbot]

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

[Enteee]

@jekyllbot bad robot !

[pathawks]

It seems like there isn’t significant momentum behind this issue.

[parkr]

If anyone is interested in creating a pull request for this, here's the line with the limit:

jekyll-feed/lib/jekyll-feed/feed.xml

Line 46 in eee0245

{% for post in posts limit: 10 %}

You should be able to swap out 10 for a variable like page.docs_limit. If you went with a page. variable, then you'd have to set docs_limit here:

jekyll-feed/lib/jekyll-feed/generator.rb

Lines 91 to 97 in eee0245

	file.data.merge!(
	"layout" => nil,
	"sitemap" => false,
	"xsl" => file_exists?("feed.xslt.xml"),
	"collection" => collection,
	"category" => category
	)

Then you'd have to figure out how you want this configured. Do you want the configuration in the collection config?

# THIS IS NOT IMPLEMENTED DO NOT COPY
collections:
  docs:
    feed_limit: 100

Or do you want a top-level feed key?

# THIS IS NOT IMPLEMENTED DO NOT COPY
feed:
  docs_limit: 100

[Enteee]

@pathawks i think you are wrong - search your own issue tracker or follow some of the linked issues in @joereynolds first comment. You'll find an almost endless list of people requesting this. But i think most people just gave up.

[megamorf]

This is one of the reasons why I'm in the process of migrating to hugo.

[parkr]

Unfortunately, the Jekyll team does not have the time to implement this particular feature right now. I outlined what would be necessary above and will be happy to review a pull request adding the feature by a contributor.

[Enteee]

@parkr there were several pr's opened for this in the past which all never made in into master

• Configurable posts limit, instead of hardcoded limit 10 posts #213
• make the number of feed entries configurable #107
• ...

What are the odds that when I do open a pull request that it will be rejected by @pathawks because it apparently "adds too much complexity"? So can you maybe discuss this, and give me feedback whether this has a chance of being merged. If yes I'm happy to go ahead and create another pull request.

[ashmaroli]

@Enteee I'm one of the maintainers of this plugin.
If you're able to submit a straight-forward pull request complete with tests and documentation, I'll guarantee an approval / merge when everything looks good.

If you're going to base your work on a commit that got rejected in the past, I'd recommend using the co-author metadata in your commit as an attribution to the original author.

[pathawks]

@Enteee I won't reject a PR to add this feature.

If we can provide an interface for this like @parkr has outlined above, I believe we can add valuable functionality to the plugin without adding too much complexity.

I'm in 👍

[Enteee]

@pathawks @ashmaroli @parkr see related pr #314