Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for categories frontmatter #153

Merged
merged 17 commits into from Jun 23, 2020
Merged

add support for categories frontmatter #153

merged 17 commits into from Jun 23, 2020

Conversation

pathawks
Copy link
Member

@pathawks pathawks commented Jan 5, 2017 •
edited

Replaces #130

Fixes #129

@pathawks pathawks mentioned this pull request Jan 5, 2017
Closed
benbalter
benbalter previously approved these changes Jan 5, 2017
View reviewed changes
@pathawks pathawks dismissed benbalter’s stale review January 5, 2017 20:27

I had to add some tests, which required creating a second fixture site. Could you tell me if this is sane, or if maybe there is a better way to do this?

@pathawks
Copy link
Member Author

pathawks commented Jan 5, 2017

I had to create a second fixture site because the feed is limited to 10 items, and the feed already contained 10 items 😂

pathawks
pathawks commented Jan 5, 2017
View reviewed changes
spec/jekyll-feed_spec.rb Outdated
post = feed.items.first
expect(post.categories[0].term).to eql('1')
expect(post.categories[1].term).to eql('2')
expect(post.categories[2].term).to eql('3')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I should name the categories first, second, third?

@pathawks pathawks added this to the v1.0.0 milestone Feb 17, 2017
@dreamalligator
Copy link
Contributor

thanks @pathawks!

@danilowoz
Copy link

Please, someone, merge it 🙏

DirtyF
DirtyF approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is failing

@dreamalligator
Copy link
Contributor

thanks for pushing this forward all

@n1k0
Copy link

n1k0 commented Sep 3, 2019

Do we have any news with this? Would be nice being able to support the categories front matter property; right now configuring feed: categories: in _config.yml will generate empty feeds for post categories using categories instead of category, which is super misleading to newcomers.

@DirtyF DirtyF requested review from DirtyF and ashmaroli and removed request for benbalter September 3, 2019 15:41
@SGOrava
Copy link

SGOrava commented Oct 17, 2019

Do we have any news with this? Would be nice being able to support the categories front matter property; right now configuring feed: categories: in _config.yml will generate empty feeds for post categories using categories instead of category, which is super misleading to newcomers.

Oh man, can you put this into README ?
This killed this plugin for me, unusable.

@ashmaroli
Copy link
Member

@pathawks I pushed changes to how this was tested. Do you have any issues with the current diff..?

@ashmaroli ashmaroli requested review from a team and removed request for DirtyF and ashmaroli October 21, 2019 16:36
@DirtyF DirtyF modified the milestones: v1.0.0, Next minor version Nov 13, 2019
@jeffgable
Copy link

As @SGOrava mentioned, until this is merged and released, can you at least put it in the README that "categories" frontmatter is not supported? Not knowing that just cost me two hours.

@DirtyF

This comment has been minimized.

Sign in to view
@DirtyF
Copy link
Member

DirtyF commented Jun 23, 2020

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 5adc83a into master Jun 23, 2020
@jekyllbot jekyllbot deleted the pull/categories branch June 23, 2020 11:08
jekyllbot added a commit that referenced this pull request Jun 23, 2020
@jekyllbot
Update history to reflect merge of #153 [ci skip]
59375d6
@dreamalligator
Copy link
Contributor

wonderful

@DirtyF DirtyF mentioned this pull request Jun 23, 2020
Open
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Merged
@jekyll jekyll locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@dreamalligator dreamalligator dreamalligator approved these changes

@benbalter benbalter benbalter left review comments

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
Next minor version
Development

Successfully merging this pull request may close these issues.

support both category and categories front-matter
10 participants
@pathawks @dreamalligator @danilowoz @n1k0 @SGOrava @ashmaroli @jeffgable @DirtyF @benbalter @jekyllbot