From 1f92ebecba77d11189551060166bd094aa4b3ea8 Mon Sep 17 00:00:00 2001
From: Guilherme Simoes <guilherme.rdems@gmail.com>
Date: Fri, 10 Apr 2020 22:51:13 +0100
Subject: [PATCH] Fix generation of feed when post title contains HTML (#305)

Merge pull request 305
---
 lib/jekyll-feed/feed.xml                            | 6 ++++--
 spec/fixtures/_posts/2014-03-04-march-the-fourth.md | 1 +
 spec/jekyll-feed_spec.rb                            | 4 ++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/jekyll-feed/feed.xml b/lib/jekyll-feed/feed.xml
index 4d4fd16d..a7417ec2 100644
--- a/lib/jekyll-feed/feed.xml
+++ b/lib/jekyll-feed/feed.xml
@@ -45,8 +45,10 @@
   {% endif %}
   {% for post in posts limit: 10 %}
     <entry{% if post.lang %}{{" "}}xml:lang="{{ post.lang }}"{% endif %}>
-      <title type="html">{{ post.title | smartify | strip_html | normalize_whitespace | xml_escape }}</title>
-      <link href="{{ post.url | absolute_url }}" rel="alternate" type="text/html" title="{{ post.title | xml_escape }}" />
+      {% assign post_title = post.title | smartify | strip_html | normalize_whitespace | xml_escape %}
+
+      <title type="html">{{ post_title }}</title>
+      <link href="{{ post.url | absolute_url }}" rel="alternate" type="text/html" title="{{ post_title }}" />
       <published>{{ post.date | date_to_xmlschema }}</published>
       <updated>{{ post.last_modified_at | default: post.date | date_to_xmlschema }}</updated>
       <id>{{ post.id | absolute_url | xml_escape }}</id>
diff --git a/spec/fixtures/_posts/2014-03-04-march-the-fourth.md b/spec/fixtures/_posts/2014-03-04-march-the-fourth.md
index 817ee53b..3e3ff140 100644
--- a/spec/fixtures/_posts/2014-03-04-march-the-fourth.md
+++ b/spec/fixtures/_posts/2014-03-04-march-the-fourth.md
@@ -1,4 +1,5 @@
 ---
+title: <span class="highlight">Sparkling</span> Title
 tags:
  - '"/><VADER>'
 image:
diff --git a/spec/jekyll-feed_spec.rb b/spec/jekyll-feed_spec.rb
index 9dce5cea..aa5596fb 100644
--- a/spec/jekyll-feed_spec.rb
+++ b/spec/jekyll-feed_spec.rb
@@ -87,6 +87,10 @@
     expect(contents).to match '<title type="html">The plugin will properly strip newlines.</title>'
   end
 
+  it "strips HTML from link titles" do
+    expect(contents).to match %r!<link .* title="Sparkling Title" />!
+  end
+
   it "renders Liquid inside posts" do
     expect(contents).to match "Liquid is rendered."
     expect(contents).not_to match "Liquid is not rendered."