Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate configuration from CLI options #76

Merged
merged 3 commits into from Oct 31, 2018
Merged

Generate configuration from CLI options #76

merged 3 commits into from Oct 31, 2018

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Oct 8, 2018 •
edited

Summary

  • Every call to Jekyll.configuration outputs a Configuration file: [file_path] to the terminal. So, its better to generate the config hash from cli options once and pass that hash to subsequent steps
  • Initialize Compose::ArgParser subclasses with both cli options and the generated config to keep the two concerns separate and avoid clobbering.

Resolves #73

DirtyF
DirtyF approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @ashmaroli

@DirtyF DirtyF mentioned this pull request Oct 8, 2018
Merged
@DirtyF DirtyF requested a review from a team October 18, 2018 12:34
@DirtyF
Copy link
Member

DirtyF commented Oct 31, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 5413e92 into jekyll:master Oct 31, 2018
jekyllbot added a commit that referenced this pull request Oct 31, 2018
@jekyllbot
Update history to reflect merge of #76 [ci skip]
bf68687
@ashmaroli ashmaroli deleted the config-from-options branch October 31, 2018 13:13
@jekyll jekyll locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid unecessary configuration logs
3 participants
@ashmaroli @DirtyF @jekyllbot