Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch point to gh-pages on user pages #111

Closed
CGarces opened this issue Aug 31, 2017 · 7 comments
Closed

Branch point to gh-pages on user pages #111

CGarces opened this issue Aug 31, 2017 · 7 comments

Comments

@CGarces
Copy link

CGarces commented Aug 31, 2017

After change my layouts to use i see the the url generated point to the gh-pages branch, than not exist.

My blog is a user blog and only contains master as relevant branch.

I can't see in the documentation how set up the branch

@benbalter
Copy link
Contributor

We can't speak to the specifics of your local se up. If you contact GitHub support they should be able to help you get things straightened out.

@CGarces
Copy link
Author

CGarces commented Sep 5, 2017

Not looks like a github issue, fails on my local environment and my CI environment.

Is the branch used by the plugin harcoded?

This is my current workflow:

  • I create a new branch with the modification at local environment ->link point to gh-pages branch (wrong)
  • Push the changes and send the PR. The PR trigger the CI tasks at codeship.com->link point to gh-pages branch (wrong)
  • Accept the PR, the CI build is launched again ->link point to gh-pages branch (wrong)
  • The page is rebuild by github ->link point to master branch (Ok)

@benbalter
Copy link
Contributor

@CGarces See #110. This is a known issue with a fix awaiting testing. If you're able to test that pull request and it resolves your issue we can get it merged and released.

@CGarces
Copy link
Author

CGarces commented Sep 7, 2017

After update the build to 2.9.2:

Jekyll build still generates the page pointing to gh-pages

but manually change the _config.yml just works for me

github:
  source:
    branch: master

Note that this workaround not was working on 2.9.1

@benbalter
Copy link
Contributor

@CGarces it sounds like your initial issue was resolved with that workaround, correct?

@CGarces
Copy link
Author

CGarces commented Sep 7, 2017

Yes, is fixed with the workaround, but I still don't know why the plugin generate the url with gh-pages as branch.
Feel free to fix the issue if is a duplicate of a existing one.

@benbalter
Copy link
Contributor

I still don't know why the plugin generate the url with gh-pages as branch.

gh-pages is the default branch for project sites (e.g., sites not in the form of username.github.io). If you don't have an API token set, it may not be able to get the repo's true branch settings, so it falls back to the default. Explicitly setting it via config is a valid workaround and is intended to do just that! 😄

@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants