Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #38

Merged
merged 6 commits into from Jul 11, 2019
Merged

Update dependencies #38

merged 6 commits into from Jul 11, 2019

Conversation

matijagaspar
Copy link
Contributor

I updated the versions of joi, core-js, mocha and temp to newer versions. I ran all the tests and they pass.

This gets rid of the warrning regarding joi (#37)

@sodatea
Copy link

sodatea commented May 12, 2019

joi is now moved to @hapi/joi

@matijagaspar
Copy link
Contributor Author

I will update the pr

@andrewbruno
Copy link

First of all, great library and thank you.

I was wondering there are any plans to update the release with these updates?

Currently receiving these warnings for devDependency

"wait-on": "^3.2.0"

npm WARN deprecated joi@13.7.0: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated hoek@5.0.4: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
npm WARN deprecated topo@3.0.3: This module has moved and is now available at @hapi/topo. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated core-js@1.2.7: core-js@<2.6.5 is no longer maintained. Please, upgrade to core-js@3 or at least to actual version of core-js@2.
npm WARN deprecated hoek@6.1.3: This module has moved and is now available at @hapi/hoek. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.

Currently:

wait-on@3.2.0
└─┬ joi@13.7.0
├── hoek@5.0.4, etc...

If there is anything I can do to help out, please let me know :)

Cheers,
Andrew

@matijagaspar
Copy link
Contributor Author

matijagaspar commented May 14, 2019

Updated the package.json to use the @hapi/joi

I also removed support (travis tests) for Node 6 because joi is no longer compatible with it.

Furthermore Node 6 is no longer maintained and is end-of-life since 2019-04-30 (https://github.com/nodejs/Release)

@andrewbruno
Copy link

That's great - Thanks. Could a new version of wait-on be published? Current at v3.2.0

@matijagaspar
Copy link
Contributor Author

Yes please!

@danonunez
Copy link

@matijagaspar please see the review from @paulmelnikow , thanks for pull-request and new version. Regards.

@jeffbski jeffbski merged commit 5c72236 into jeffbski:master Jul 11, 2019
@jeffbski
Copy link
Owner

Published to npm wait-on@3.3.0

I updated mocha@6.1.4 to fix a security audit warning.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants