Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript support #32

Open
belozer opened this issue Nov 23, 2019 · 3 comments
Open

Add TypeScript support #32

belozer opened this issue Nov 23, 2019 · 3 comments

Comments

@belozer
Copy link
Contributor

belozer commented Nov 23, 2019

Because typing is mainstream now
@Shaker-Hamdi
Copy link

Shaker-Hamdi commented Dec 29, 2019 •
edited

Yup, I just installed this package and was ready to use it just to find out there are no types for it. So it would be great to add TypeScript support.

I had to go with "react-tabs" just because of this :(

@sashayudaev
Copy link

@Shaker-Hamdi why use react-tabs if you could temporarily add your own typings? The library is rather small so it shouldn't be lots of work.

@Shaker-Hamdi
Copy link

Shaker-Hamdi commented Feb 11, 2020 •
edited

@sashayudaev When you're in a hurry to meet the deadline, any amount of extra work will hurt you. Plus I'm not that fond of Typescript, to begin with :D.
So the idea of typing something that I didn't build myself and figuring out the types gives me anxiety just by thinking about it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belozer @Shaker-Hamdi @sashayudaev