fix: remove inconsistencies when using React.StrictMode #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 5, 2021 10:23
replace tab and panel counting based on render cycles with children as unique keys Fixes issues jeetiss#219
|
Hello @jeetiss let me know if there's something to improve! Thanks 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #219.
To do so a change was done in the way
<Tab>and<Panel>are counted. Previously<Tab>and<Panel>were counted based on how many times the relative hooks were called, such a usage was a problem when using<React.StrictMode>that duplicates renders during development.The way we corrected this issue is by caching the children of the
<Tab>or<Panel>components in an array, making sure that only unique children get pushed into the cache. With this we only changed the way the index is calculated.Fixes #219