Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: adjust columns to use least space when merged #238

Merged
merged 9 commits into from Nov 5, 2022
Merged

table: adjust columns to use least space when merged #238

merged 9 commits into from Nov 5, 2022

Conversation

jedib0t
Copy link
Owner

@jedib0t jedib0t commented Nov 5, 2022

Proposed Changes

  • do not use max space for a column that is being merged
  • consider the total merged length when calculating a column's width

Fixes #226.

@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3401685065

  • 107 of 107 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 3170487164: 0.0%
Covered Lines: 3231
Relevant Lines: 3231
💛 - Coveralls

@jedib0t jedib0t merged commit 006d8ca into main Nov 5, 2022
@jedib0t jedib0t deleted the table-complete-merge branch November 5, 2022 21:14
@jedib0t jedib0t mentioned this pull request Nov 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about AutoMerge option
2 participants
@jedib0t @coveralls