list: add unindent all function #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2786577285
💛 - Coveralls |
jedib0t
reviewed
Aug 2, 2022
jedib0t
requested changes
Aug 2, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ok, added some tests! |
jedib0t
reviewed
Aug 3, 2022
|
@mneira10 I've merged the PR. Let me know if you need a tag, or if it can wait. |
|
A tag would be nice! But I'm not in a hurry, I can wait for it to get bundled with other stuff for a little bit |
|
Tags are cheap. I’ll get you one within the hour.
…________________________________
From: Mauricio Neira ***@***.***>
Sent: Tuesday, August 2, 2022 8:08:04 PM
To: jedib0t/go-pretty ***@***.***>
Cc: Naveen Mahalingam ***@***.***>; State change ***@***.***>
Subject: Re: [jedib0t/go-pretty] list: add unindent all function (PR #217)
A tag would be nice! But I'm not in a hurry, I can wait for it to get bundled with other stuff for a little bit
—
Reply to this email directly, view it on GitHub<#217 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJGJS34AW2D6EXRJHUVXKMTVXHPBJANCNFSM55J56PNQ>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds a function to unindent the list item to the base of the list, regardless of the indentation level its in.
I wrote this up after needing it in my personal projects. WDYT?