New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress: refactor visibility options (Show*); fixes #196 #199

Merged

jedib0t merged 1 commit into main from progress-eta

Apr 14, 2022

Owner

jedib0t commented Apr 14, 2022

Proposed Changes

Deprecate all the Show* interfaces in progress.Progress and progress.Writer
Introduce progress.Style.Visibility with same defaults as before
Introduce progress.Style.Visibility.ETAOverall as a new option for addressing bug The "overall" ETA is always displayed even if ShowETA is false. #196


          progress: refactor visibility options (Show*); fixes #196

4f747e5

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

coveralls commented Apr 14, 2022

Pull Request Test Coverage Report for Build 2168565276

28 of 28 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 2030349230:	0.0%
Covered Lines:	3047
Relevant Lines:	3047

💛 - Coveralls

jedib0t merged commit 35b05aa into main

jedib0t deleted the progress-eta branch

April 14, 2022 17:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment