Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested transactions with db_session #53

Open
cybergrind opened this issue Sep 14, 2021 · 0 comments · May be fixed by #54
Open

Nested transactions with db_session #53

cybergrind opened this issue Sep 14, 2021 · 0 comments · May be fixed by #54

Comments

@cybergrind
Copy link

Can anyone clarify if it is expected behavior? It seems like nested transactions don't work and I'm not sure if it should be fixed or not.

def test_rollback_nested(person, db_session):
    assert db_session.query(person).count() == 0
    n1 = db_session.begin_nested()
    db_session.add(person())
    assert db_session.query(person).count() == 1
    n2 = db_session.begin_nested()
    db_session.add(person())
    assert db_session.query(person).count() == 2
    n2.rollback()
    assert db_session.query(person).count() == 1  # Fails, we have 2 records in db
    n1.rollback()
    assert db_session.query(person).count() == 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SesstionTransaction._connection_for_bind call. Fixes #53 cybergrind/pytest-flask-sqlalchemy
1 participant
@cybergrind