Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ResultIterable<T> methods for single row results #1511

Merged
merged 3 commits into from Apr 24, 2019
Merged

Add new ResultIterable<T> methods for single row results #1511

merged 3 commits into from Apr 24, 2019

Conversation

qualidafial
Copy link
Member

@qualidafial qualidafial commented Apr 23, 2019 •
edited

  • one() : T - throws if zero or multiple rows returned
  • findOne() : Optional<T> - throws if multiple rows returned
  • first() : T - throws if zero rows returned
  • Deprecate findOnly() in favor of one()

Fixes #1498

Add new ResultIterable methods for single row results
b25b728 
- one() : T - throws if zero or multiple rows returned
- findOne() : Optional<T> - throws if multiple rows returned
- first() : T - throws if zero rows returned
- Deprecate findOnly() in favor of one()
leaumar
leaumar approved these changes Apr 23, 2019
View reviewed changes
Copy link

@leaumar leaumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sweet

@qualidafial qualidafial mentioned this pull request Apr 23, 2019
Closed
findepi
findepi reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

core/src/main/java/org/jdbi/v3/core/result/ResultIterable.java Show resolved Hide resolved
core/src/test/java/org/jdbi/v3/core/statement/TestQueries.java Show resolved Hide resolved
docs/src/adoc/index.adoc Outdated Show resolved Hide resolved
stevenschlansker
stevenschlansker approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@stevenschlansker stevenschlansker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

core/src/main/java/org/jdbi/v3/core/result/ResultIterable.java Show resolved Hide resolved
core/src/main/java/org/jdbi/v3/core/result/ResultIterable.java Show resolved Hide resolved
core/src/main/java/org/jdbi/v3/core/result/ResultIterable.java Show resolved Hide resolved
@stevenschlansker stevenschlansker merged commit 985de45 into master Apr 24, 2019
@stevenschlansker stevenschlansker deleted the result-iterable-single-row-methods branch April 24, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenschlansker stevenschlansker stevenschlansker approved these changes

@findepi findepi findepi left review comments

@leaumar leaumar leaumar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to get the only row if present?
4 participants
@qualidafial @stevenschlansker @findepi @leaumar