Skip to content

fix(mypy): add missing typing #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix(mypy): add missing typing #384

merged 2 commits into from
Jan 30, 2023

Conversation

sileht
Copy link
Collaborator

@sileht sileht commented Jan 30, 2023

Runtime callbacks for retry/stop/wait allow to pass a function or a
class that inherit from retry_base/wait_base/stop_base.

This fixes the typing when a function is used.

Fixes #324

@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2023

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

Runtime callbacks for retry/stop/wait allow to pass a function or a
class that inherit from retry_base/wait_base/stop_base.

This fixes the typing when a function is used.

Fixes jd#324
@sileht sileht added the no-changelog No changelog needed label Jan 30, 2023
@sileht sileht closed this Jan 30, 2023
@sileht sileht reopened this Jan 30, 2023
@sileht
Copy link
Collaborator Author

sileht commented Jan 30, 2023

@Mergifyio update

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mergify
Copy link
Contributor

mergify bot commented Jan 30, 2023

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit d9438b3 into jd:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No changelog needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using stop, wait and retry custom callbacks with Retrying causes mypy failures
2 participants