Skip to content

Support datetime.timedelta as a valid wait unit type #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2022
Merged

Support datetime.timedelta as a valid wait unit type #342

merged 3 commits into from
May 30, 2022
+65 −47

Conversation

noambloom
Copy link
Contributor

Closes #341

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from 60a7700 to be71cdb Compare January 30, 2022 10:17
@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from be71cdb to e3716a6 Compare February 21, 2022 13:12
@noambloom
Copy link
Contributor Author

@jd do you mind taking a look please? Thanks :)

@jd
Copy link
Owner

jd commented Apr 27, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2022

rebase

☑️ Nothing to do

  • -closed [:pushpin: rebase requirement]
  • #commits-behind>0 [:pushpin: rebase requirement]

Sorry, something went wrong.

jd
jd previously requested changes Apr 27, 2022
View reviewed changes
@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from 011b454 to 68932bd Compare May 25, 2022 15:12
@mergify mergify bot dismissed jd’s stale review May 25, 2022 15:13

Pull request has been modified.

@noambloom noambloom requested a review from jd May 26, 2022 08:37
jd
jd previously requested changes May 26, 2022
View reviewed changes
Copy link
Owner

@jd jd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to have a couple of tests also, even if typing makes it work in theory.

Support datetime.timedelta as a valid wait unit type
874bcaf 
Signed-off-by: Noam Bloom <nbloom5@bloomberg.net>
@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from 68932bd to 874bcaf Compare May 26, 2022 14:20
@mergify mergify bot dismissed jd’s stale review May 26, 2022 14:20

Pull request has been modified.

@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from 4e702ef to a7c59e1 Compare May 27, 2022 08:49
Add datetime.timedelta support tests
faa0006 
Signed-off-by: Noam Bloom <nbloom5@bloomberg.net>
@noambloom noambloom force-pushed the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch from a7c59e1 to faa0006 Compare May 27, 2022 08:51
@noambloom noambloom requested a review from jd May 27, 2022 08:51
jd
jd previously approved these changes May 27, 2022
View reviewed changes
@mergify mergify bot dismissed jd’s stale review May 27, 2022 15:21

Pull request has been modified.

@noambloom noambloom requested a review from jd May 28, 2022 17:51
@mergify mergify bot merged commit 18d05a6 into jd:main May 30, 2022
@noambloom noambloom deleted the SUPPORT_TIMEDELTA_WAIT_UNIT_TYPE branch May 30, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support timedelta as a valid type for wait classes
2 participants
@noambloom @jd