Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docking window extension #826

Open
1 of 4 tasks
jcubic opened this issue Sep 12, 2022 · 8 comments
Open
1 of 4 tasks

Add docking window extension #826

jcubic opened this issue Sep 12, 2022 · 8 comments
Labels
Milestone

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 12, 2022

I have an idea for a new feature for jQuery Terminal

Include with the package:

Ref: https://codepen.io/jcubic/pen/ExwpEwB?editors=0110

API:

$.terminal.docking(function(command, term) {

}, { options });

alternative:

$.terminal.docking({ options }).terminal(...);

And docking will return div inside the container for adding the terminal.

An additional option will be the initial state, docking: boolean;

TODO:

  • Add resize from LIPS bookmark
  • Add event onClose
  • Add option buttons to allow different icons, the default will be: minimize and close.
  • Create CodePen demo
@jcubic jcubic added the feature label Sep 12, 2022
@jcubic jcubic added this to the 2.35.0 milestone Sep 12, 2022
@jcubic jcubic modified the milestones: 2.35.0, 2.36.0 Dec 12, 2022
@jcubic jcubic modified the milestones: 2.36.0, 2.37.0 May 19, 2023
@Adarsh-Dhar
Copy link

Hey can I contribute to this issue .I am a first year undergrad and want to start my opensource journey

@jcubic
Copy link
Owner Author

jcubic commented Oct 3, 2023

Sure

@jcubic
Copy link
Owner Author

jcubic commented Oct 4, 2023

@Adarsh-Dhar Do you need help?

@Adarsh-Dhar
Copy link

Adarsh-Dhar commented Oct 4, 2023

can you list what all techstack i need to know for this issue.I already know html , css, js, react., jQuery

@jcubic
Copy link
Owner Author

jcubic commented Oct 4, 2023

JavaScript, CSS, HTML, jQuery

@Adarsh-Dhar
Copy link

also could you please elaborate what i have to do

@jcubic
Copy link
Owner Author

jcubic commented Oct 4, 2023

You need to take the code that is in the links in the issue and put it together. You can start by using one of the files in js directory as base, because you need UMD module definition in the file.

@jcubic
Copy link
Owner Author

jcubic commented Dec 29, 2023

Working Window Docking demo with localStorage persistance

It's better to name the extension window() because docking({ docking: true }) would look odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants