Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changing scrollbar color #821

Open
jcubic opened this issue Sep 11, 2022 · 6 comments
Open

Document changing scrollbar color #821

jcubic opened this issue Sep 11, 2022 · 6 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 11, 2022

I have an idea for a new feature for jQuery Terminal

With 9be6df5 you can now change the style of the scrollbar.

.terminal-scroller {
    --color: #0050ff;
}

This need to be added to Wiki.

@jcubic jcubic added the feature label Sep 11, 2022
@jcubic jcubic added this to the 2.35.0 milestone Sep 11, 2022
@jcubic
Copy link
Owner Author

jcubic commented Sep 11, 2022

Also update this demo https://codepen.io/jcubic/pen/oNXqJWY

@sumitbishti
Copy link

sumitbishti commented Sep 29, 2022

I can work on it and other similar issues!

@jcubic
Copy link
Owner Author

jcubic commented Sep 29, 2022

@sumitbishti it needs to wait for when version 2.35.0 is released but you can take #737. It's updating README with the most important examples from Wiki.

@jcubic
Copy link
Owner Author

jcubic commented Sep 29, 2022

@sumitbishti another issue that is not written but you can take is updating documentation for the website jquery.terminal-www on API references are a lot of missing methods and options. The best is to just go to the TypeScript definition file and document what is missing you can also check Wiki that is more up to date.

It requires checking both documents and writing in a PHP file (where most are just HTML) the missing features. Any updates that will improve documentation are welcome.

@sumitbishti
Copy link

I would need directions on how to go about that?

@sumitbishti it needs to wait for when version 2.35.0 is released but you can take #737. It's updating README with the most important examples from Wiki.

@jcubic
Copy link
Owner Author

jcubic commented Oct 27, 2022

Sorry for the late reply, I don't know how to explain it more clearly. There is a need to go into Wiki and check the most fundamental examples and put them into README. Sorry, I can't explain what is the most fundamental example. I would need to check Wiki myself and point you to fundamental examples, which is the point of the task.

@jcubic jcubic modified the milestones: 2.35.0, 2.36.0 Dec 12, 2022
@jcubic jcubic modified the milestones: 2.36.0, 2.37.0 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants