Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enter typing animation doesn't work with prompt that return value #724

Closed
jcubic opened this issue Dec 23, 2021 · 0 comments
Closed

enter typing animation doesn't work with prompt that return value #724

jcubic opened this issue Dec 23, 2021 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 23, 2021

Issue summary

When there is prompt that return string, exec and enter typing animation doesn't work

Expected behavior

Animation works as in other places

Actual behavior

Animation doesn't work

Steps to reproduce

  1. Open Fake Linux Terminal Demo
  2. Run $.terminal.active().exec(['ls'], { typing: true });
  3. Nothing happens, because the value is ignored and callback function (for prompt) is not called.
@jcubic jcubic added the Bug label Dec 23, 2021
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 23, 2021
@jcubic jcubic closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant