Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make execAnimation work only with execHash #723

Closed
jcubic opened this issue Dec 23, 2021 · 0 comments
Closed

Make execAnimation work only with execHash #723

jcubic opened this issue Dec 23, 2021 · 0 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 23, 2021

I have an idea for a new feature for jQuery Terminal

Tere is no need to execAnimation to work with every single exec, sice user can control the typing animation when he/she call the function. But he/she can't control the animation when doing exec from URL hash. So it would be better for execAnimation to work only with execHash.
@jcubic jcubic added the feature label Dec 23, 2021
jcubic added a commit that referenced this issue Dec 26, 2021
@jcubic
add termina::enter API + improve execAnimation #723
509f280
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 26, 2021
@jcubic jcubic closed this as completed Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic