Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echo with newline: false doesn't work with flush: false #709

Closed
jcubic opened this issue Nov 25, 2021 · 0 comments
Closed

echo with newline: false doesn't work with flush: false #709

jcubic opened this issue Nov 25, 2021 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Nov 25, 2021

Issue summary

Next echo with flush: false is not updating the line

Steps to reproduce

Open https://codepen.io/jcubic/pen/JjygoOg

  1. type: foo <enter> bar <enter> baz <enter> flush <enter>
@jcubic jcubic added the Bug label Nov 25, 2021
jcubic added a commit that referenced this issue Dec 13, 2021
@jcubic
fix multiple echo with !newline + !flush #709
1a15536
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 13, 2021
jcubic added a commit that referenced this issue Dec 13, 2021
@jcubic
add unit tests #709
af710c0
jcubic added a commit that referenced this issue Dec 14, 2021
@jcubic
fix another edge case in #709 + refactor #717
80754fb 
* fix case when echo two lines with echo newline and flush false
* refactor get_output_buffer function
* rename clear_buffer
@jcubic jcubic closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic