Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL with hash table should be added instantly #703

Closed
jcubic opened this issue Nov 8, 2021 · 0 comments
Closed

URL with hash table should be added instantly #703

jcubic opened this issue Nov 8, 2021 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Nov 8, 2021

Issue summary

When you have long async command and you're recording the commands in hash, the command need to finish to update the URL

Expected behavior

URL is updated instantly

Actual behavior

URL is updated when the command finishes.

Steps to reproduce

  1. Open https://jcubic.github.io/git/
  2. run record start
  3. clone any repo
@jcubic jcubic added the Bug label Nov 8, 2021
jcubic added a commit that referenced this issue Dec 13, 2021
@jcubic
fix updating hash for long async commands #703
9957159
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 13, 2021
@jcubic jcubic closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic