Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow role attributes in html tags #332

Merged
merged 1 commit into from
May 28, 2020

Conversation

eric-wieser
Copy link
Contributor

https://stackoverflow.com/questions/10403138/what-is-the-purpose-of-the-role-attribute-in-html

In my case, the motivation is to allow <img src="math.svg" role="math" />.

@gjtorikian
Copy link
Owner

Yeah, that makes sense. Thanks!

@gjtorikian gjtorikian merged commit 565eaee into gjtorikian:master May 28, 2020
@gjtorikian
Copy link
Owner

This is out now as 2.13.0.

@eric-wieser
Copy link
Contributor Author

Out of curiosity, do you have a feel for the length of the pipeline between your release and GitHub using it for readme contents?

@gjtorikian
Copy link
Owner

GitHub doesn't use this gem.

@eric-wieser
Copy link
Contributor Author

eric-wieser commented May 28, 2020

Looks like I was led here by mistake! github/markup#245 (comment) is clearly out of date.

Oh well, hope someone benefits from this change.

@gjtorikian
Copy link
Owner

Ah, yeah, sorry! They move to an internal fork, so perhaps try contacting their Support team?

FWIW the README mentions GitHub's not using this: https://github.com/jch/html-pipeline#htmlpipeline-

Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants