Set AccessControlContext to null on termination to release captured c… #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Aug 2, 2021
| @@ -191,7 +191,7 @@ | |||
| * The access control context of the creating thread. | |||
| * Will be set to null when the MBean is not registered. | |||
| */ | |||
| private final AccessControlContext acc; | |||
| private volatile AccessControlContext acc; | |||
There was a problem hiding this comment.
Is volatile necessary given that it's only updated via completeTermination?
There was a problem hiding this comment.
Yes I think it's better to make it volatile. It certainly doesn't hurt.
|
I've added also commit b3cb132 to fix a problem I introduced in my previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lassloaders
Followup to #108 as suggested by @dmlloyd