Remove the ViewExecutor artificial size limit #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the previous implementations, EnhancedViewExecutor stores state in a 64-bit integer, allowing both the pool and queue sizes to use full integers. There's not any reason to create an executor with more than 32k active tasks, however the builder uses the `int` type so it's nice to allow `Integer.MAX_VALUE` to have effectively the same impact as `Short.MAX_VALUE` and rely on the compiler for input validation.
|
Very low priority, I just realized I should have removed the cast and assert when I removed the old ViewExecutor implementations. |
dmlloyd
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the previous implementations, EnhancedViewExecutor stores
state in a 64-bit integer, allowing both the pool and queue
sizes to use full integers.
There's not any reason to create an executor with more than 32k
active tasks, however the builder uses the
inttype so it's niceto allow
Integer.MAX_VALUEto have effectively the same impactas
Short.MAX_VALUEand rely on the compiler for input validation.