You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a detach() is invoked on a CtClass object, it throws a NullPointerException as mentioned in #370 and in #258, I have seen your response but I don't think it is a good practice to let users receive unexpected NullPointerExceptions. It is not specifically twice detach() invocations in a row that results in that error. My code calls ClassPool.getDefault().get() once and detaches it safely, however, once I perform that cycle again it results in NullPointerException. As I understand from the documentation ClassPool#get(String) reads from the class file and returns CtClass object and on the other hand, detach() causes that CtClass object to be removed from the cache. It is a natural expectation that a new CtClass object should be created by reading the .class file once again when user calls ClassPool.getDefault().get(String) and it must allow users to safely detach from the class pool.
My fix is just a no-brainer, and probably just evades the problem rather than solving it.
I am still getting the null pointer issue in the version 3.27.0-GA
Caused by: java.lang.NullPointerException
at javassist.ClassPool.cacheCtClass(ClassPool.java:236)
at javassist.CtClass.detach(CtClass.java:1427)
at com.microsoft.intune.mam.TransformationUnit.writeClassesToDirectory(TransformationUnit.java:275)
at com.microsoft.intune.mam.TransformationUnit.writeOutput(TransformationUnit.java:126)
at com.microsoft.intune.mam.BuildTimeMamifier.mamify(BuildTimeMamifier.java:131)
at com.microsoft.intune.mam.MamifyTransformBase.transform(MamifyTransformBase.java:195)
at com.android.build.gradle.internal.pipeline.TransformTask$2.call(TransformTask.java:284)
at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:69)
... 126 more
New issue Link
https://github.com/jboss-javassist/javassist/issues/442
I am still getting the null pointer issue in the version 3.27.0-GA
Caused by: java.lang.NullPointerException at javassist.ClassPool.cacheCtClass(ClassPool.java:236) at javassist.CtClass.detach(CtClass.java:1427) at com.microsoft.intune.mam.TransformationUnit.writeClassesToDirectory(TransformatinUnit.java:275) at com.microsoft.intune.mam.TransformationUnit.writeOutput(TransformationUnit.java:126) at com.microsoft.intune.mam.BuildTimeMamifier.mamify(BuildTimeMamifier.java:131) at com.microsoft.intune.mam.MamifyTransformBase.transform(MamifyTransformBase.java:195) at com.android.build.gradle.internal.pipeline.TransformTask$2.call(TransformTask.java:284) at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:69) ... 126 more
New issue Link
https://github.com/jboss-javassist/javassist/issues/442
the code was committed on 2021/09/21, and the 3.27.0-GA was released on 2020/03/19. You need 3.29.0-GA which is released after the code solved date.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
detach()is invoked on aCtClassobject, it throws aNullPointerExceptionas mentioned in #370 and in #258, I have seen your response but I don't think it is a good practice to let users receive unexpectedNullPointerExceptions. It is not specifically twicedetach()invocations in a row that results in that error. My code callsClassPool.getDefault().get()once and detaches it safely, however, once I perform that cycle again it results inNullPointerException. As I understand from the documentationClassPool#get(String)reads from the class file and returnsCtClassobject and on the other hand,detach()causes thatCtClassobject to be removed from the cache. It is a natural expectation that a newCtClassobject should be created by reading the.classfile once again when user callsClassPool.getDefault().get(String)and it must allow users to safely detach from the class pool.My fix is just a no-brainer, and probably just evades the problem rather than solving it.