Only wrap the method name if the method doesn't come from the same declaring class #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... I ran into an issue with inner classes again... This time the compiler renames valid method calls when a method is private. The test setup looks like this:
When generating an invoker which is an inner class of the
Test
class the compiler will generate this:but the invocation would work perfectly fine as the caller is an inner class of the Test class and allowed to call the method in that way. After the change the compiler generates this method:
which is exactly what i was expecting to get and which works perfectly fine. This change was tested against jvm versions
HotSpot 1.8.0_241-b07
,HotSpot 11.0.6+8-LTS
andHotSpot 18-ea+12-613