add functions for getting the parameter names of method #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NingZhang-e
reviewed
Jan 29, 2021
| public String variableNameByIndex(int index) { | ||
| for (int i = 0; i < tableLength(); i++) { | ||
| if (index(i) == index) { | ||
| return getConstPool().getUtf8Info(nameIndex(i)); |
There was a problem hiding this comment.
Had better use variableName(i)
NingZhang-e
reviewed
Jan 29, 2021
| * @param i the position of the parameter. | ||
| */ | ||
| public String parameterName(int i) { | ||
| return getConstPool().getUtf8Info(name(i)); |
There was a problem hiding this comment.
Add unit tests for the changes.
…hodParametersAttribute.parameterName
|
@NingZhang-e Thanks for review, I added unit tests. |
NingZhang-e
approved these changes
Jan 29, 2021
odl-github
pushed a commit
to opendaylight/odlparent
that referenced
this pull request
Jan 7, 2022
jboss-javassist/javassist#305 jboss-javassist/javassist#328 jboss-javassist/javassist#339 jboss-javassist/javassist#350 jboss-javassist/javassist#357 jboss-javassist/javassist#363 Change-Id: I29963013cf637731fe1064425b9d2e80d63bd9d3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
odl-github
pushed a commit
to opendaylight/odlparent
that referenced
this pull request
Jan 7, 2022
jboss-javassist/javassist#305 jboss-javassist/javassist#328 jboss-javassist/javassist#339 jboss-javassist/javassist#350 jboss-javassist/javassist#357 jboss-javassist/javassist#363 Change-Id: I29963013cf637731fe1064425b9d2e80d63bd9d3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> (cherry picked from commit 0df0ba3)
odl-github
pushed a commit
to opendaylight/odlparent
that referenced
this pull request
Jan 7, 2022
jboss-javassist/javassist#305 jboss-javassist/javassist#328 jboss-javassist/javassist#339 jboss-javassist/javassist#350 jboss-javassist/javassist#357 jboss-javassist/javassist#363 Change-Id: I29963013cf637731fe1064425b9d2e80d63bd9d3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> (cherry picked from commit 0df0ba3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalVariableAttribute.javafor getting correct local variable name by given index. ThevariableNamemethod has some ambiguities for get the parameter names of method, see How to get method parameter names with javassist? #14 , Obtained incorrect original parameter name of method by MethodInfo API #16 , how to get the methd parameter name? #131 . Thelocal_variable_tablemay appear in any order, sovariableNamemethod give incorrect value.MethodParametersAttribute.javafor getting parameter names.