JDK11: BAD LDC: 17 (Dynamic Class-File Constants) #282

harshilps · 2019-10-16T23:10:59Z

#270 I thought that the PR/merge would make javassist fully compatible with Dynamic Class-File Constants(https://openjdk.java.net/jeps/309). When running junit tests using powermock on the Java 11 I get this error: "BAD LDC 17". Here Javassist and Mockito is used as a dependency of PowerMock.
I am using the following versions.

Javassist 3.26.0-GA
PowerMock 2.0.2
JDK 11
Mockito 2.28.0

valfirst · 2019-10-17T11:51:13Z

I've faced with this issue as well, here is an exception stack trace:

...
Caused by: java.lang.RuntimeException: bad LDC: 17
	at javassist.bytecode.stackmap.Tracer.doLDC(Tracer.java:267)
	at javassist.bytecode.stackmap.Tracer.doOpcode0_53(Tracer.java:167)
	at javassist.bytecode.stackmap.Tracer.doOpcode(Tracer.java:73)
	at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:195)
	at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:172)
	at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:116)
	at javassist.bytecode.MethodInfo.rebuildStackMap(MethodInfo.java:458)
	at javassist.bytecode.MethodInfo.rebuildStackMapIf6(MethodInfo.java:440)
	at javassist.expr.ExprEditor.doit(ExprEditor.java:118)
	at javassist.CtClassType.instrument(CtClassType.java:1541)
	at org.powermock.core.transformers.javassist.InstrumentMockTransformer.transform(InstrumentMockTransformer.java:41)
	at org.powermock.core.transformers.javassist.AbstractJavaAssistMockTransformer.transform(AbstractJavaAssistMockTransformer.java:40)
	at org.powermock.core.transformers.support.DefaultMockTransformerChain.transform(DefaultMockTransformerChain.java:43)
	at org.powermock.core.classloader.MockClassLoader.transformClass(MockClassLoader.java:184)
	at org.powermock.core.classloader.javassist.JavassistMockClassLoader.defineAndTransformClass(JavassistMockClassLoader.java:102)
	... 106 more

harshilps · 2019-10-17T16:33:17Z

Did you get around solving it? or like do you have any fix for this issue?

chibash · 2019-10-17T16:35:38Z

I'll check this.

harshilps · 2019-11-26T17:58:26Z

I'll check this.

Any update on a fix?

chibash · 2019-11-27T11:14:37Z

Not yet, but I'm working on this.

tiagorico · 2019-12-19T02:50:08Z

Any update on this?

chibash · 2019-12-23T00:59:33Z

Is there anyone who kindly writes a Java source file that is compiled into a class file including the bytecode ldc with CONSTANT_Dynamic?

chibash · 2019-12-23T09:39:37Z

Can anyone check javassist.jar available from master/HEAD?
I hope it will fix the bug.

SurpSG · 2019-12-23T12:32:10Z

Hi @chibash
Seems, the issue is fixed with javassist.jar from master/HEAD

chibash · 2019-12-23T13:43:32Z

Great, thanks to @SurpSG

harshilps · 2019-12-24T17:35:12Z

@chibash Are there any plans to release a new version with this feature any time soon?

chibash · 2019-12-24T17:36:51Z

Until the end of this year?

harshilps · 2019-12-24T17:40:07Z

Not particularly before the end of this year just in general.

valfirst · 2020-02-20T10:00:28Z

@chibash do you have plans to release a new version in the near future?

andreimozgo · 2020-03-17T12:29:49Z

@chibash @valfirst Could you please release a new version?

valfirst · 2020-03-17T14:27:05Z

@andreimozgo I'm just a contributor, I can't release it, I'm waiting for release as you and anybody else 😄

chibash · 2020-03-17T14:45:11Z

Sorry for my silence. I'll release within a day.

chibash · 2020-03-18T18:17:03Z

I have done. The new release will be available soon from maven (but I must ask someone else to upload).

lewe518 · 2020-03-19T07:48:37Z

@chibash Could you please upload the new version to mvnrepository ?

chibash · 2020-03-19T08:02:59Z

I don't have an access permission.

chibash · 2020-03-19T13:55:59Z

Now it's on maven.

bergerst · 2020-05-12T09:03:27Z

So can this issue be closed?

arturkii · 2020-06-10T08:50:09Z

Did anybody find working versions combination? i try to migrate to java 11 and have the same issue.
i use:
JDK 11
mockito-core : 2.28.1
powermock-module-junit4: 2.0.2
powermock-api-mockito2: 2.0.2
javassist: 3.26.0-GA

still have
java.lang.IllegalStateException: Failed to transform class with name <someclass>. Reason: bad LDC: 17 Caused by: java.lang.RuntimeException: bad LDC: 17

tried to play with versions in different cases have different exception.

valfirst · 2020-06-10T08:52:32Z

@Artke I recommend to use PowerMock 2.0.6 and higher

arturkii · 2020-06-10T09:20:33Z

tried with higher versions
PowerMock 2.0.6
Mockito 3.3.3
javassist 3.27.0-GA
still have
java.lang.IllegalStateException: Failed to transform class with name <name>. Reason: bad LDC: 17 Caused by: java.lang.RuntimeException: bad LDC: 17

valfirst · 2020-06-10T09:23:10Z

@Artke could you please make sure you don't have another version of javassist in classpath? also could you post the full exception stacktrace?

arturkii · 2020-06-10T09:43:40Z

@valfirst powermock-module-junit4:2.0.7 has javassist 3.27.0-GA within itself so i deleted my extra dependency. so now i have
PowerMock 2.0.6
Mockito 3.3.3
Java 11
... and new exception

	at jdk.internal.reflect.GeneratedSerializationConstructorAccessor6.newInstance(Unknown Source)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.objenesis.instantiator.sun.SunReflectionFactoryInstantiator.newInstance(SunReflectionFactoryInstantiator.java:48)
	at org.objenesis.ObjenesisBase.newInstance(ObjenesisBase.java:73)
	at org.mockito.internal.creation.instance.ObjenesisInstantiator.newInstance(ObjenesisInstantiator.java:19)
	at org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:47)
	at org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:25)
	at org.powermock.api.mockito.mockmaker.PowerMockMaker.createMock(PowerMockMaker.java:41)
	at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:35)
	at org.mockito.internal.MockitoCore.mock(MockitoCore.java:63)
	at org.mockito.Mockito.mock(Mockito.java:1908)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.createMethodInvocationControl(DefaultMockCreator.java:108)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.doCreateMock(DefaultMockCreator.java:61)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.createMock(DefaultMockCreator.java:53)
	at org.powermock.api.mockito.internal.mockcreation.DefaultMockCreator.mock(DefaultMockCreator.java:40)
	at org.powermock.api.mockito.PowerMockito.mock(PowerMockito.java:181)
	at org.powermock.api.extension.listener.AnnotationEnabler.standardInject(AnnotationEnabler.java:98)
	at org.powermock.api.extension.listener.AnnotationEnabler.beforeTestMethod(AnnotationEnabler.java:55)
	at org.powermock.tests.utils.impl.PowerMockTestNotifierImpl.notifyBeforeTestMethod(PowerMockTestNotifierImpl.java:82)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:308)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:131)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.access$100(PowerMockJUnit47RunnerDelegateImpl.java:59)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner$TestExecutorStatement.evaluate(PowerMockJUnit47RunnerDelegateImpl.java:147)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.evaluateStatement(PowerMockJUnit47RunnerDelegateImpl.java:107)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:298)
	at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86)
	at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:218)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:160)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:134)
	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:33)
	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:45)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:136)
	at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:117)
	at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:57)
	at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
Caused by: java.lang.IllegalStateException: Failed to transform class with name org.apache.hadoop.fs.FileSystem$Cache. Reason: org.apache.hadoop.fs.FileSystem$Cache$Key class is frozen
	at org.powermock.core.classloader.javassist.JavassistMockClassLoader.defineAndTransformClass(JavassistMockClassLoader.java:119)
	at org.powermock.core.classloader.MockClassLoader.loadMockClass(MockClassLoader.java:174)
	at org.powermock.core.classloader.MockClassLoader.loadClassByThisClassLoader(MockClassLoader.java:102)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass1(DeferSupportingClassLoader.java:147)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass(DeferSupportingClassLoader.java:98)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
	at java.base/java.lang.Class.forName0(Native Method)
	at java.base/java.lang.Class.forName(Class.java:315)
	at javassist.runtime.Desc.getClassObject(Desc.java:72)
	at javassist.runtime.Desc.getClassType(Desc.java:181)
	at javassist.runtime.Desc.getType(Desc.java:151)
	at javassist.runtime.Desc.getType(Desc.java:107)
	at org.apache.hadoop.fs.FileSystem.<clinit>(FileSystem.java:103)
	... 42 more
Caused by: java.lang.RuntimeException: org.apache.hadoop.fs.FileSystem$Cache$Key class is frozen
	at javassist.CtClassType.checkModify(CtClassType.java:321)
	at javassist.CtBehavior.setModifiers(CtBehavior.java:178)
	at org.powermock.core.transformers.javassist.ConstructorsMockTransformer.transform(ConstructorsMockTransformer.java:64)
	at org.powermock.core.transformers.javassist.ConstructorsMockTransformer.transform(ConstructorsMockTransformer.java:51)
	at org.powermock.core.transformers.javassist.AbstractJavaAssistMockTransformer.transform(AbstractJavaAssistMockTransformer.java:40)
	at org.powermock.core.transformers.support.DefaultMockTransformerChain.transform(DefaultMockTransformerChain.java:43)
	at org.powermock.core.classloader.MockClassLoader.transformClass(MockClassLoader.java:184)
	at org.powermock.core.classloader.javassist.JavassistMockClassLoader.defineAndTransformClass(JavassistMockClassLoader.java:102)
	... 54 more

FileSystem.Cache.Key class its the field of tested FileSystem.class @PrepareForTest({FileSystem.class, CheckStatusStep.class})

any idea why its frozen?

harshilps · 2020-06-10T18:05:11Z

@Artke It has worked for me by using the following combination/versions:

Javassist 3.27.0-GA
PowerMock 2.0.2
JDK 11
Mockito 2.28.0

valfirst · 2020-06-10T19:59:42Z

@Artke this should help: powermock/powermock#475 (comment)

lighTQ · 2020-07-30T06:24:59Z

I add this for my testClass it solved the problem，you should try it again. may be can solve your problem.

@SuppressStaticInitializationFor("org.apache.hadoop.fs.FileSystem")
@RunWith(PowerMockRunner.class)
@PowerMockIgnore("javax.management.*") // resolve classloader conflict

PowerMockit 2.02
JDK 1.8

vikaskhengare · 2020-08-20T23:00:34Z

Hi All,

We are trying to migrate the code from JDK 8 to 11. Old code was using old versions of javassist, powermock and mockito.

Now we are trying with following combination,
javassist - 3.27.0-GA
powermock - 2.0.2
mockito - 2.28.2
JDK - 11

While doing this, we got following error,
java.lang.IllegalStateException: Failed to transform class with name com.mycompany.constant.MyConstants. Reason: com.mycompany.constant.MyConstants$SomeEnum class is frozen

java.lang.IllegalStateException: Failed to transform class with name com.mycompany.constant.MyConstants. Reason: com.mycompany.constant.MyConstants$SomeEnum class is frozen
	at org.powermock.core.classloader.javassist.JavassistMockClassLoader.defineAndTransformClass(JavassistMockClassLoader.java:119)
	at org.powermock.core.classloader.MockClassLoader.loadMockClass(MockClassLoader.java:174)
	at org.powermock.core.classloader.MockClassLoader.loadClassByThisClassLoader(MockClassLoader.java:102)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass1(DeferSupportingClassLoader.java:147)
	at org.powermock.core.classloader.DeferSupportingClassLoader.loadClass(DeferSupportingClassLoader.java:98)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
	at com.cisco.config.base.logger.ConfigLiteLoggerFactory.isDownloadSessionLoggerEnabled(ConfigLiteLoggerFactory.java:195)
	at com.cisco.config.base.logger.ConfigLiteLogger.getLogger(ConfigLiteLogger.java:453)
	at com.cisco.config.base.logger.ConfigLiteLogger.error(ConfigLiteLogger.java:413)
	at com.cisco.config.meraki.resource.FinalResponseResource.getDoneResponse(FinalResponseResource.java:70)
	at com.cisco.config.meraki.resource.test.FinalResponseResourceTest.getDoneResponseTest(FinalResponseResourceTest.java:97)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
	at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:326)
	at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:88)
...
...
Caused by: java.lang.RuntimeException: com.mycompany.constant.MyConstants$SomeEnum class is frozen
	at javassist.CtClassType.checkModify(CtClassType.java:321)
	at javassist.CtBehavior.setModifiers(CtBehavior.java:178)
	at org.powermock.core.transformers.javassist.ConstructorsMockTransformer.transform(ConstructorsMockTransformer.java:64)
	at org.powermock.core.transformers.javassist.ConstructorsMockTransformer.transform(ConstructorsMockTransformer.java:51)
	at org.powermock.core.transformers.javassist.AbstractJavaAssistMockTransformer.transform(AbstractJavaAssistMockTransformer.java:40)
	at org.powermock.core.transformers.support.DefaultMockTransformerChain.transform(DefaultMockTransformerChain.java:43)
	at org.powermock.core.classloader.MockClassLoader.transformClass(MockClassLoader.java:184)
	at org.powermock.core.classloader.javassist.JavassistMockClassLoader.defineAndTransformClass(JavassistMockClassLoader.java:102)

Does anyone know why do we get this error and how to resolve it?

What do class frozen means?

Thanks in advance!

valfirst mentioned this issue Oct 30, 2019

Test failure on JDK11 with PowerMock + JaCoCo offline instrumentation powermock/powermock#1017

Closed

chibash added a commit that referenced this issue Dec 23, 2019

fixdes Issue #282

559bc90

chibash closed this as completed May 12, 2020

pbludov mentioned this issue Feb 15, 2021

Issue #9146: upgrade minimal required jdk version to 11 checkstyle/checkstyle#9281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK11: BAD LDC: 17 (Dynamic Class-File Constants) #282

JDK11: BAD LDC: 17 (Dynamic Class-File Constants) #282

harshilps commented Oct 16, 2019

valfirst commented Oct 17, 2019

harshilps commented Oct 17, 2019

chibash commented Oct 17, 2019

harshilps commented Nov 26, 2019 •

edited

chibash commented Nov 27, 2019

tiagorico commented Dec 19, 2019

chibash commented Dec 23, 2019

chibash commented Dec 23, 2019

SurpSG commented Dec 23, 2019 •

edited

chibash commented Dec 23, 2019

harshilps commented Dec 24, 2019

chibash commented Dec 24, 2019

harshilps commented Dec 24, 2019

valfirst commented Feb 20, 2020

andreimozgo commented Mar 17, 2020

valfirst commented Mar 17, 2020

chibash commented Mar 17, 2020

chibash commented Mar 18, 2020

lewe518 commented Mar 19, 2020

chibash commented Mar 19, 2020

chibash commented Mar 19, 2020

bergerst commented May 12, 2020

arturkii commented Jun 10, 2020 •

edited

valfirst commented Jun 10, 2020

arturkii commented Jun 10, 2020

valfirst commented Jun 10, 2020

arturkii commented Jun 10, 2020 •

edited

harshilps commented Jun 10, 2020

valfirst commented Jun 10, 2020

lighTQ commented Jul 30, 2020

vikaskhengare commented Aug 20, 2020

JDK11: BAD LDC: 17 (Dynamic Class-File Constants) #282

JDK11: BAD LDC: 17 (Dynamic Class-File Constants) #282

Comments

harshilps commented Oct 16, 2019

valfirst commented Oct 17, 2019

harshilps commented Oct 17, 2019

chibash commented Oct 17, 2019

harshilps commented Nov 26, 2019 • edited

chibash commented Nov 27, 2019

tiagorico commented Dec 19, 2019

chibash commented Dec 23, 2019

chibash commented Dec 23, 2019

SurpSG commented Dec 23, 2019 • edited

chibash commented Dec 23, 2019

harshilps commented Dec 24, 2019

chibash commented Dec 24, 2019

harshilps commented Dec 24, 2019

valfirst commented Feb 20, 2020

andreimozgo commented Mar 17, 2020

valfirst commented Mar 17, 2020

chibash commented Mar 17, 2020

chibash commented Mar 18, 2020

lewe518 commented Mar 19, 2020

chibash commented Mar 19, 2020

chibash commented Mar 19, 2020

bergerst commented May 12, 2020

arturkii commented Jun 10, 2020 • edited

valfirst commented Jun 10, 2020

arturkii commented Jun 10, 2020

valfirst commented Jun 10, 2020

arturkii commented Jun 10, 2020 • edited

harshilps commented Jun 10, 2020

valfirst commented Jun 10, 2020

lighTQ commented Jul 30, 2020

vikaskhengare commented Aug 20, 2020

harshilps commented Nov 26, 2019 •

edited

SurpSG commented Dec 23, 2019 •

edited

arturkii commented Jun 10, 2020 •

edited

arturkii commented Jun 10, 2020 •

edited