Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back FactoryHelper.toClass(ClassFile cf, ClassLoader loader, Prot… #254

Merged

Conversation

soul2zimate
Copy link
Contributor

…ectionDomain domain) for backward compatibility in minor release.
6320bc4#diff-ddec044ab147cbae4c1402c4be2aacacR127 changed the FactoryHelper.toClass method signature. This breaks Hibernate use.

I see there is no major version 4 plan yet. But, can we simply add previous deprecated method signature back with neighbor to null ?

…ectionDomain domain) for backward compatibility in minor release.
@scottmarlow
Copy link
Contributor

@chibash fyi, Hibernate ORM currently is using this method. @soul2zimate would like to bring this method back in, so we can use the javassist version (3.24.2 after released) with Hibernate ORM. Make sense?

@soul2zimate
Copy link
Contributor Author

Can anyone review this change please?

@chibash chibash merged commit a332834 into jboss-javassist:master Apr 8, 2019
@chibash
Copy link
Member

chibash commented Apr 8, 2019

The added method could still run on Java 11 but you would see a warning message printed by the JVM (jigsaw).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants