ClassPool.makePackage alternative for for Java11

[vamsi360]

Hi,

We were using classPool.makePackage(currClassLoader, ctClass.getPackageName()) in our code to create a package at runtime.

This is deprecated in Java9+. What is the recommended way of achieving this in Java11? Could you point me to the resources on how to fix this?

[vamsi360]

Note: Adding --add-opens java.base/java.lang=ALL-UNNAMED (as described in javadocs) in VM options also doesn't seem to work for me in JDK11

[NingZhang-e]

Seems the java doc in ClassPool is incorrect and needs to be update:

javassist/src/main/javassist/ClassPool.java

Line 1249 in f36195c

* <p>The jigsaw module introduced by Java 9 has broken this method.

Due to it will not be supported in Java9+:

javassist/src/main/javassist/util/proxy/DefinePackageHelper.java

Line 50 in f36195c

throw new RuntimeException("define package has been disabled for jigsaw");

[NingZhang-e]

One PR to update java doc:
#247

[vamsi360]

hi @NingZhang-e
how to makePackage now at runtime going forward? How to migrate existing code? Is there any other way?

[NingZhang-e]

I can not figure out a graceful way to go forward. Because define new package conflict with jigsaw policy.
Suggest to abandon make package usage if you want to uplift to Java9+. And make class under one existing package, e.g. org.javassist.