JAVASSIST-242: Demonstrates a race condition in DefineClassHelper + proposed fix #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2019 11:28
Don't try to clean-up after making a protected-final method accessible. No synchronization with concurrent access can cause errors.
michalkurka
changed the title
Pscheidl
reviewed
Jan 25, 2019
| @@ -219,9 +219,6 @@ private final Method getDefineClassMethod() { | |||
| if (e instanceof RuntimeException) throw (RuntimeException) e; | |||
| throw new CannotCompileException(e); | |||
| } | |||
| finally { | |||
| SecurityActions.setAccessible(defineClass, false); | |||
There was a problem hiding this comment.
Let's quote the reason I approved:
As other posters have indicated, setAccessible is only applicable to that instance, so setting the accessibility back to its original state is not needed.
Pscheidl
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #242