Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for the same Python object/anchor does not reload page but just gets stuck on the search preview #200

Open
jgarte opened this issue Jan 4, 2023 · 4 comments
Labels
feat: Search Related to search feature

Comments

@jgarte
Copy link

jgarte commented Jan 4, 2023

This is related to #198.

@jbms Thanks for the fix!

There is one edge case which is when you jump to the Python object and then try to search for the exact same Python object again, the search gets stuck and doesn't allow you to click.

I can imagine it working this way or reloading the same page with the same anchor.

What do you think?

@jbms
Copy link
Owner

jbms commented Jan 5, 2023

I filed an upstream issue in mkdocs-material for this: squidfunk/mkdocs-material#4829

@jbms
Copy link
Owner

jbms commented Jan 9, 2023

This is now fixed in upstream, we just need to pull in those changes.

@2bndy5
Copy link
Collaborator

2bndy5 commented Jan 9, 2023

I looked at that recently. Looks like upstream had a major version bump since our last update...

@jbms
Copy link
Owner

jbms commented Jan 9, 2023

I looked at that recently. Looks like upstream had a major version bump since our last update...

Yes, definitely non-trivial this time around. I created #203 to track.

@2bndy5 2bndy5 added the feat: Search Related to search feature label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: Search Related to search feature
Projects
None yet
Development

No branches or pull requests

3 participants