Fix invalid ComputeHash from ByteByffer array computation #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/mvid-fix
branch
from
e1c6c05
to
aeda499
Compare
|
@jbevain Is it expected that lots of tests are failing with this message ? |
marek-safar
reviewed
Oct 18, 2019
| @@ -146,7 +146,7 @@ static void CopyStreamChunk (Stream stream, Stream dest_stream, byte [] buffer, | |||
|
|
|||
| using (var crypto_stream = new CryptoStream (Stream.Null, sha1, CryptoStreamMode.Write)) { | |||
| for (int i = 0; i < buffers.Length; i++) { | |||
| crypto_stream.Write (buffers [0].buffer, 0, buffers [0].length); | |||
| crypto_stream.Write (buffers [i].buffer, 0, buffers [i].length); | |||
11 tasks
|
@jeromelaban thanks for the PR and for finding this. Obviously the errors are unexpected. No idea what changed since it's been working fine, I suspect a change in the GitHub actions VM environment. I'll look into that, in the meantime, this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #770, where MVID computation in deterministic mode can be incorrect