Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/prometheus/client_golang: CVE-2022-21698 #200

Open
jba opened this issue Mar 1, 2022 · 0 comments

Comments

@jba
Copy link
Owner

jba commented Mar 1, 2022

In CVE-2022-21698, the reference URL github.com/prometheus/client_golang (and possibly others) refers to something in Go.

module: github.com/prometheus/client_golang
package: client_golang
description: |
    client_golang is the instrumentation library for Go applications in Prometheus, and the promhttp package in client_golang provides tooling around HTTP servers and clients. In client_golang prior to version 1.11.1, HTTP server is susceptible to a Denial of Service through unbounded cardinality, and potential memory exhaustion, when handling requests with non-standard HTTP methods. In order to be affected, an instrumented software must use any of `promhttp.InstrumentHandler*` middleware except `RequestsInFlight`; not filter any specific methods (e.g GET) before middleware; pass metric with `method` label name to our middleware; and not have any firewall/LB/proxy that filters away requests with unknown `method`. client_golang version 1.11.1 contains a patch for this issue. Several workarounds are available, including removing the `method` label name from counter/gauge used in the InstrumentHandler; turning off affected promhttp handlers; adding custom middleware before promhttp handler that will sanitize the request method given by Go http.Request; and using a reverse proxy or web application firewall, configured to only allow a limited set of methods.
cves:
  - CVE-2022-21698
links:
    pr: https://github.com/prometheus/client_golang/pull/987
    context:
      - https://github.com/prometheus/client_golang/releases/tag/v1.11.1
      - https://github.com/prometheus/client_golang/security/advisories/GHSA-cg3q-j54f-5p7p

See doc/triage.md for instructions on how to triage this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant