Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pip minimum version to >= 20.3 #1340

Merged
merged 3 commits into from Mar 8, 2021

Conversation

atugushev
Copy link
Member

Due to pip-tools' policy to support only the last two minor pip versions, it's time to drop the pip-20.1 and pip-20.2.

Latest: 21.0.*
Previous: 20.3.*

Changelog-friendly one-liner: Bump pip minimum version to >= 20.3.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 6.0.0 milestone Mar 7, 2021
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #1340 (e3b0cf5) into master (4f89da8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files          33       33              
  Lines        2928     2915      -13     
  Branches      319      313       -6     
==========================================
- Hits         2917     2904      -13     
  Misses          5        5              
  Partials        6        6              
Impacted Files Coverage Δ
tests/test_resolver.py 100.00% <ø> (ø)
piptools/repositories/pypi.py 97.11% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f89da8...d9ab55d. Read the comment docs.

Copy link
Member

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment is very minor and cosmetic. Otherwise, looks great. Thanks for cleaning this up!

tests/test_resolver.py Outdated Show resolved Hide resolved
@atugushev atugushev merged commit 74aa521 into jazzband:master Mar 8, 2021
@atugushev atugushev deleted the bump-minimal-version-pip-20.3 branch March 8, 2021 04:42
@atugushev
Copy link
Member Author

Thanks @jdufresne for reviewing this! Much appreciated 👍🏼

@atugushev atugushev added the dependency Related to a dependency label Mar 11, 2021
This was referenced Mar 14, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Related to a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants