Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling input setup file in nested folders #1324

Merged
merged 2 commits into from Feb 24, 2021

Conversation

peymanslh
Copy link
Member

@peymanslh peymanslh commented Feb 14, 2021

Closes #1312

Changelog-friendly one-liner: Fix compiling input setup.py file in nested folders

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1324 (a92734a) into master (2be5cbf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1324   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          33       33           
  Lines        2921     2928    +7     
  Branches      318      318           
=======================================
+ Hits         2910     2917    +7     
  Misses          5        5           
  Partials        6        6           
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <100.00%> (ø)
tests/test_cli_compile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5cbf...a92734a. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peymanslh thanks! Could you add a test for this particular case?

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! A few comments below:

tests/test_cli_compile.py Outdated Show resolved Hide resolved
tests/test_cli_compile.py Outdated Show resolved Hide resolved
piptools/scripts/compile.py Outdated Show resolved Hide resolved
Add unit test

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fix some issues

Co-authored-by: Albert Tugushev <albert@tugushev.ru>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@atugushev
Copy link
Member

@AndydeCleyre it's okay if we merge this before #1329? What do you think?

@atugushev atugushev added the setuptools Related to compiling requirements form setup.py label Feb 24, 2021
@AndydeCleyre
Copy link
Contributor

@AndydeCleyre it's okay if we merge this before #1329? What do you think?

Sure, I still need to add more tests, I'll rebase later and iron any wrinkles out.

@atugushev atugushev added this to the 6.0.0 milestone Feb 24, 2021
@atugushev atugushev merged commit 1931e21 into jazzband:master Feb 24, 2021
@atugushev
Copy link
Member

Wonderfull! Thanks, @peymanslh!

@peymanslh
Copy link
Member Author

Wonderfull! Thanks, @peymanslh!

Thanks for your review and suggestion!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setuptools Related to compiling requirements form setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling setup.py in a nested folder produces setup.txt
3 participants