Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventually implement support for the PEP 735 "dependency groups" #2062

Open
webknjaz opened this issue Feb 27, 2024 · 6 comments
Open

Eventually implement support for the PEP 735 "dependency groups" #2062

webknjaz opened this issue Feb 27, 2024 · 6 comments
Labels
enhancement Improvements to functionality feature Request for a new feature needs discussion Need some more discussion pyproject.toml Related to pyproject.toml support

Comments

@webknjaz
Copy link
Member

What's the problem this feature will solve?

It's just a new source of deps and an extension to the first round of the pyproject.toml runtime deps resolution.

Describe the solution you'd like

$sbj. If somebody's interested in making a PoC, it's probably fine to start drafting something already. Need to wait for the PEP acceptance to actually merge it in, though.

Alternative Solutions

... not doing this?

Additional context

Refs:

@webknjaz webknjaz added enhancement Improvements to functionality feature Request for a new feature needs discussion Need some more discussion pyproject.toml Related to pyproject.toml support labels Feb 27, 2024
@chrysle
Copy link
Contributor

chrysle commented Apr 4, 2024

What are you planning to have for dependency group support? An option to collect only such dependencies, or alongside with normal and build deps? And the possibility to collect only specified dependency groups?

@webknjaz
Copy link
Member Author

webknjaz commented Apr 4, 2024

Same as #1960 attempted, just in the proper place. Semantically, dependency groups don't imply including runtime dependencies so they should definitely be collected and output separately. However, we shouldn't actively prevent combining them with other deps (runtime, or runtime+extra, or other dependency groups; though the latter seems to be covered by the PEP itself).

@chrysle
Copy link
Contributor

chrysle commented Apr 4, 2024

However, we shouldn't actively prevent combining them with other deps

IIUC that would mean actually creating an option like --include-dependency-groups/--all-dependency-groups, next to --only-dependency-groups?

@webknjaz
Copy link
Member Author

webknjaz commented Apr 5, 2024

Aren't the past two the same?

@chrysle
Copy link
Contributor

chrysle commented Apr 5, 2024

Aren't the past two the same?

Yes, this was unintended. Is the rest of my assumption valid?

@webknjaz
Copy link
Member Author

webknjaz commented Apr 7, 2024

I think so. It of course could be iterated on during a PoC review..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality feature Request for a new feature needs discussion Need some more discussion pyproject.toml Related to pyproject.toml support
Projects
None yet
Development

No branches or pull requests

2 participants