Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build CI job #1771

Merged
merged 1 commit into from Dec 12, 2022
Merged

Fix build CI job #1771

merged 1 commit into from Dec 12, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Dec 11, 2022

Forgot to install setuptools-scm.

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Forgot to install setuptools-scm.
@atugushev atugushev added ci Related to continuous integration tasks skip-changelog Avoid listing in changelog labels Dec 11, 2022
@atugushev
Copy link
Member Author

Perhaps there is no need in printing version by setuptools-scm at all. After building sdist and wheel build would print a version of builded packages:

$ python -m build
...
Successfully built pip-tools-6.11.0.tar.gz and pip_tools-6.11.0-py3-none-any.whl

What do you think?

@ssbarnea ssbarnea merged commit 6a24854 into jazzband:main Dec 12, 2022
@atugushev atugushev deleted the fix-build-job branch December 12, 2022 09:46
@ssbarnea
Copy link
Member

@atugushev Yeah, I would know toi look for archive versions to see version. BTW, if you spot an issue with versioning let me know, I know few tuning tricks if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants