Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1 of GitHub action pypa/gh-action-pypi-publish #1744

Merged
merged 1 commit into from Nov 22, 2022

Conversation

michael-k
Copy link
Contributor

The master branch version has been sunset, see https://github.com/pypa/gh-action-pypi-publish#-master-branch-sunset-

At the moment there's no diff between master and release/v1, see pypa/gh-action-pypi-publish@master...release/v1

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

The `master` branch version has been sunset, see
https://github.com/pypa/gh-action-pypi-publish#-master-branch-sunset-

At the moment there's no diff between `master` and `release/v1`, see
pypa/gh-action-pypi-publish@master...release/v1
@michael-k michael-k added ci Related to continuous integration tasks skip-changelog Avoid listing in changelog labels Nov 22, 2022
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@atugushev atugushev enabled auto-merge (squash) November 22, 2022 17:40
@atugushev atugushev merged commit a524d98 into jazzband:main Nov 22, 2022
@webknjaz
Copy link
Member

At the moment there's no diff between master and release/v1, see pypa/gh-action-pypi-publish@master...release/v1

That is not entirely correct :)
You're linking a "three-dot diff" performed in the wrong direction.
https://github.com/pypa/gh-action-pypi-publish/compare/master..release/v1 and pypa/gh-action-pypi-publish@release/v1...master will correctly show the changes — two commits to be precise.
Yes, they are non-functional and only relate to showing the deprecation message but still, they are changes.

@michael-k michael-k deleted the pypi-publish branch November 24, 2022 16:18
@michael-k
Copy link
Contributor Author

You're linking a "three-dot diff" performed in the wrong direction.

Let me rephrase: At the moment there are no new commits in release/v1 compared to master.

But you're right, I should have checked the other way as well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants