Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.12 #1728

Merged
merged 1 commit into from Nov 14, 2022
Merged

Test on Python 3.12 #1728

merged 1 commit into from Nov 14, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Nov 13, 2022

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added the ci Related to continuous integration tasks label Nov 13, 2022
@atugushev atugushev marked this pull request as ready for review November 13, 2022 15:45
@ssbarnea ssbarnea added the skip-changelog Avoid listing in changelog label Nov 14, 2022
@ssbarnea ssbarnea merged commit a61f2f4 into jazzband:master Nov 14, 2022
@webknjaz
Copy link
Member

@atugushev instead of deadsnakes you could just use ~3.12.0-0 from GH

@atugushev
Copy link
Member Author

atugushev commented Nov 14, 2022

@webknjaz I followed the pattern in ci.yaml. Isn't "deadsnakes" builds main python nightly which is why we use it?

@atugushev atugushev deleted the test-on-python312 branch November 14, 2022 08:20
@webknjaz
Copy link
Member

Yes and no. Deadsnakes builds CPython's repo branch every day. It is truly unstable.
GitHub builds tagged releases, they are updated less frequently, providing less surprises every day.
Originally, deadsnakes were used because GH was slow to provide alphas and to emulate what Travis CI used to have.
So depending on the motivation, you might want to use one or the other.

@atugushev
Copy link
Member Author

@webknjaz thanks for the info. I guess we can switch to GHA completely then. I'll open a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration tasks skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants