Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit output requirement file to test the exact output #1725

Merged
merged 1 commit into from Nov 12, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Nov 12, 2022

When a test asserts the exact content of the output requirement file make sure it uses the output file not stderr, otherwise the test will fail when something appears in stderr (e.g., a warning).

Addresses #1724 (comment).

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

When a test asserts the exact content of the output requirement file
make sure it uses the output file not stderr, otherwise the test will
fail when something appears in stderr (e.g., a warning).
@atugushev atugushev added tests Testing and related things skip-changelog Avoid listing in changelog labels Nov 12, 2022
@atugushev atugushev mentioned this pull request Nov 12, 2022
@atugushev atugushev added this to the 6.10.0 milestone Nov 12, 2022
@ssbarnea ssbarnea merged commit 56d5f62 into jazzband:master Nov 12, 2022
@atugushev atugushev deleted the check-output-file branch November 12, 2022 20:13
@atugushev
Copy link
Member Author

Thanks @ssbarnea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Avoid listing in changelog tests Testing and related things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants