Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure isort to add from __future__ import annotations #1695

Merged
merged 7 commits into from
Nov 9, 2022
Merged

configure isort to add from __future__ import annotations #1695

merged 7 commits into from
Nov 9, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Oct 7, 2022 •
edited

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@graingert graingert added the skip-changelog Avoid listing in changelog label Oct 7, 2022
@graingert graingert mentioned this pull request Oct 7, 2022
Draft
4 tasks
webknjaz
webknjaz approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good if it doesn't break the backwards compatibility.

atugushev
atugushev approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert!

@atugushev atugushev enabled auto-merge (squash) November 9, 2022 01:16
@atugushev atugushev merged commit 1c67754 into jazzband:master Nov 9, 2022
@graingert graingert deleted the enable-future-annotations branch November 9, 2022 10:19
dand-oss pushed a commit to dand-oss/pip-tools that referenced this pull request Nov 12, 2022
@graingert
configure isort to add from __future__ import annotations (jazzband…
e369f62 
…#1695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@graingert @webknjaz @atugushev