Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog for 6.9.0 release #1693

Merged
merged 2 commits into from Oct 5, 2022
Merged

Update changelog for 6.9.0 release #1693

merged 2 commits into from Oct 5, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 5, 2022 •
edited

No description provided.

@ssbarnea ssbarnea added the skip-changelog Avoid listing in changelog label Oct 5, 2022
@atugushev atugushev added this to the 6.9.0 milestone Oct 5, 2022
@ssbarnea ssbarnea enabled auto-merge (squash) October 5, 2022 14:16
webknjaz
webknjaz reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changelog should be well-formatted and use the past tense that appeared/changed since the previous release. It shouldn't use imperative mood. Its consumers are the end-users, after all.

@ssbarnea ssbarnea disabled auto-merge October 5, 2022 18:06
@ssbarnea ssbarnea merged commit 906bf36 into jazzband:master Oct 5, 2022
@ssbarnea ssbarnea deleted the chore/release-6.9.0 branch October 5, 2022 19:38
@ssbarnea
Copy link
Member Author

ssbarnea commented Oct 5, 2022

PS. I observed the comment, but the phrasing was in sync with the last few release changelogs, so I made no change to them. Life is too short to polish these texts.

@atugushev
Copy link
Member

@ssbarnea release is uploaded. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssbarnea @atugushev @webknjaz