Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Resolver._get_install_requirements() #1664

Merged
merged 2 commits into from Oct 5, 2022
Merged

Refactor Resolver._get_install_requirements() #1664

merged 2 commits into from Oct 5, 2022

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Aug 6, 2022 •
edited

A tech-debt cleanup for updated Resolver._get_install_requirements() in #1509. Addresses #1509 (comment).

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added refactor Refactoring code skip-changelog Avoid listing in changelog labels Aug 6, 2022
@ssbarnea ssbarnea enabled auto-merge (squash) October 5, 2022 13:49
@ssbarnea ssbarnea merged commit 221dd4c into jazzband:master Oct 5, 2022
@atugushev atugushev deleted the refactor-pr-1509 branch October 5, 2022 15:38
@atugushev
Copy link
Member Author

Thanks @ssbarnea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
refactor Refactoring code skip-changelog Avoid listing in changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atugushev @ssbarnea