Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #1616

Merged
merged 5 commits into from Jun 7, 2022
Merged

Fix typos #1616

merged 5 commits into from Jun 7, 2022

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Apr 26, 2022

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@atugushev atugushev added the docs Documentation related label Apr 27, 2022
@ssbarnea
Copy link
Member

@atugushev That requirement to prevent merges on branches that are not updated does really impede making a new release as any other merge invalidates the previous runs.

@atugushev
Copy link
Member

atugushev commented May 23, 2022

That requirement to prevent merges on branches that are not updated does really impede making a new release as any other merge invalidates the previous runs.

Yeah, this is kinda annoying. Feel free to ask @jazzband/roadies on the issue tracker to disable that requirement.

See also #1085

@ssbarnea
Copy link
Member

I posed on #jazzband channel on matrix, but I am not sure is the key people are there.

@ssbarnea
Copy link
Member

@atugushev The feature is benefic in general as I know that some changes can easily break the master but maintainers should be able to bypass it. It should act more like a warning than a hard requirement.

@atugushev atugushev added the skip-changelog Avoid listing in changelog label May 29, 2022
@atugushev atugushev merged commit 2a2cece into jazzband:master Jun 7, 2022
@kianmeng
Copy link
Contributor Author

kianmeng commented Jun 8, 2022

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related skip-changelog Avoid listing in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants